Repository navigation
Phase 2e: Port keyboard input and build orchestration to Rust - #34
Merged
Merged
Conversation
Add keyboard.rs (crossterm-based non-blocking space-bar detection) and build.rs (BuildMode/BuildRequest/BuildResult types plus subprocess run_build delegate) as library modules in fastled-cli. Expose build_available() via the fastled-py PyO3 extension. Main loop still delegates to Python; these modules are the building blocks for Phase 2e integration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/fastled-cli/src/keyboard.rs: non-blocking space-bar detection viacrossterm, withcheck_for_space()(poll once, no blocking) andstart_listener()(background thread returning anmpsc::Receiver<KeyEvent>)crates/fastled-cli/src/build.rs:BuildModeenum,BuildRequestandBuildResultstructs mirroringbuild_types.py, andrun_build()which delegates topython -m fastled.app --just-compileas a subprocessbuild_available() -> boolvia thefastled-pyPyO3 extension modulemain.rs; the main loop still delegates everything to Python — integration comes in the next phaseCloses #22
Test plan
./_cargo build --workspace— compiles cleanly./_cargo test --workspace— 44 Rust tests pass (9 new: 2 keyboard, 7 build)./_cargo clippy --workspace --all-targets -- -D warnings— clean./_cargo fmt --all --check— cleanbash lint— ruff / black / isort / pyright all passbash test— 121 Python tests pass